Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-transform] Support more component definitions & expand tests #441

Merged
merged 37 commits into from
Nov 16, 2023
Merged

[react-transform] Support more component definitions & expand tests #441

merged 37 commits into from
Nov 16, 2023

Conversation

andrewiggins
Copy link
Member

Add support for auto-transforming more ways to specify components: object methods, member assignments, export default components, components wrapped in HoCs like memo and forwardRef

Also expands the react transform test suite to generate test cases based on different combinations of syntaxes.

@andrewiggins
Add transform test for memo'ed components
88b7ce3
@andrewiggins
Handle using memo and forwardRef on components in transform
7d7d8c3
@andrewiggins
Remove top-level restriction to transform components written in tests
6a8921d
@andrewiggins
Add notes about additional tests to add
bf6ed90
@andrewiggins
Add some more tests
003cf2d
@andrewiggins
Start build test generator
e4a7ee9
@andrewiggins
Add call exp wrappers and restructure generators
60063c2
@andrewiggins
Align prettier versions
95614f0
@andrewiggins
Add var decl, assignment, obj prop, export default & named generation
7198591
@andrewiggins
Simplify hoc tests to only test valid names or not
c1a882f
@andrewiggins
Always check state first before checking name
56cf7e1 
Since state should be a simple look up while reading name is an AST climb
@andrewiggins
Rename helpers extension to make TS importing work
7c36d15
@andrewiggins
Start using helpers in test file
4f6b041
@andrewiggins
Add TODO to refactor get function name methods
de1da1e
@andrewiggins
Fix assignment expression tests
30d4ad0
@andrewiggins
Add some notes to assist future debugging
b87dcda
@andrewiggins
Change formatting a bit
02c384e
@andrewiggins
Update transform to parse filename for export default components
dc17f03
@andrewiggins
WIP: Hook comment generation to tests
251a0bc 
Tests are failing cuz of bug :)
@andrewiggins
Fix searching for opt in/out comment through HoCs
71f829f
@andrewiggins
Clean up code a bit
d0dbdcc
@andrewiggins
Use block comments instead of line comments in generated code
c9349ed
@andrewiggins
Remove some redundant tests
dd2c9cf
@andrewiggins
Remove some redundant helpers
7f9c314
@andrewiggins
Cover additional test cases
9ebc6f4
@andrewiggins
Rename some older tests to make them more scan-able
1165bba
@andrewiggins
Support multiple test ids in debug helper
7642eb0
@andrewiggins
Setup inline variable comment tests
9527ce6
@andrewiggins
Fix object property tests
ab0dc8c
@andrewiggins
Update debug code again
415210d
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: ac06c35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@preact/signals-react-transform Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit ac06c35
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/65556fe30acf120008a295ab
😎 Deploy Preview https://deploy-preview-441--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Size Change: +2.3 kB (+3%)

Total Size: 82.6 kB

Filename Size Change
packages/react-transform/dist/signals-*********.js 4.26 kB +765 B (+22%) 🚨
packages/react-transform/dist/signals-transform.mjs 3.57 kB +771 B (+28%) 🚨
packages/react-transform/dist/signals-transform.umd.js 4.37 kB +766 B (+21%) 🚨
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.9 kB
docs/dist/assets/index.********.js 833 B
docs/dist/assets/jsxRuntime.module.********.js 281 B
docs/dist/assets/preact.module.********.js 4.02 kB
docs/dist/assets/signals-core.module.********.js 1.46 kB
docs/dist/assets/signals.module.********.js 2.02 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 239 B
packages/core/dist/signals-core.js 1.54 kB
packages/core/dist/signals-core.mjs 1.56 kB
packages/preact/dist/signals.js 1.27 kB
packages/preact/dist/signals.mjs 1.22 kB
packages/react/dist/signals.js 1.55 kB
packages/react/dist/signals.mjs 1.55 kB

compressed-size-action

@andrewiggins andrewiggins merged commit 4c433c3 into main Nov 16, 2023
6 checks passed
@andrewiggins andrewiggins deleted the improve-transform branch November 16, 2023 20:51
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
@andrewiggins andrewiggins mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewiggins @JoviDeCroock